clear
{{language.name}} No language found.
swap_horiz
{{language.name}} No language found.
search
TRANG TRANG 26 days ago May 5, 2020 at 6:16 PM link Permalink

**Reviews in new sentence design**

The reviews feature is ready to be tested on the dev website and as usual, we will need some people to test and report issues.

https://dev.tatoeba.org/

This is the last feature that needs to be implemented before we can switch to the new sentence design.

Note that this feature is not enabled by default. You have to enable it in your Settings with the option "Activate feature to review sentences".

Thanks!

{{vm.hiddenReplies[35102] ? 'expand_more' : 'expand_less'}} hide replies show replies
soliloquist soliloquist 26 days ago May 5, 2020 at 7:57 PM link Permalink

It works fine, thank you. I just want to say two things.

- Deleted sentences still show up on reviews/collections page, and it's not possible to remove/unmark them.

https://i.imgur.com/NRyX0aX.png

- The default view of the edit bar is minimized. To rate sentences in the list view, we need to expand the bar on each sentence. If we had an option to change the default view of the edit bar, it would be more practical for proofreading and linking.

https://streamable.com/vg9w4a

{{vm.hiddenReplies[35105] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 26 days ago May 5, 2020 at 8:27 PM link Permalink

Thanks for testing.

> Deleted sentences still show up on reviews/collections page

This is a known issue: https://github.com/Tatoeba/tatoeba2/issues/1795

> The default view of the edit bar is minimized.

There's a button in the green toolbar which will expand the menu for all sentences and keep it expanded as you go from a page to another.

{{vm.hiddenReplies[35108] ? 'expand_more' : 'expand_less'}} hide replies show replies
soliloquist soliloquist 26 days ago May 5, 2020 at 9:00 PM link Permalink

> There's a button in the green toolbar which will expand the menu for all sentences and keep it expanded as you go from a page to another.


Thanks. I didn't see that button. It's indeed available on these pages.

https://dev.tatoeba.org/eng/sen...ists/show/8909

https://dev.tatoeba.org/eng/sen...ll_in/eng/none

But it isn't available on this one as there's no green toolbar.

https://dev.tatoeba.org/eng/act...of/soliloquist

{{vm.hiddenReplies[35109] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 21 days ago May 10, 2020 at 8:23 PM link Permalink

> But it isn't available on this one as there's no green toolbar.
>
> https://dev.tatoeba.org/eng/act...of/soliloquist

Indeed. There's no toolbar yet on this page because the title is too long to fit in one line and it wouldn't be properly displayed in the toolbar.

I'll think of how to re-title this page when taking care of this issue:
https://github.com/Tatoeba/tatoeba2/issues/2074

{{vm.hiddenReplies[35142] ? 'expand_more' : 'expand_less'}} hide replies show replies
AlanF_US AlanF_US 20 days ago May 11, 2020 at 9:19 PM link Permalink

The tooltip should say "Show fewer features" rather than "Show less features".

Also, the name of the owner of the sentence is extremely important information to me, and the fact that it is no longer displayed without my having to visit the sentence itself will disrupt my workflow. I use the owner's name in many different situations. For instance, I use it when correcting sentences (since I've learned which users are no longer active and thus are unlikely to see my comments, which users have a high error rate, etc.). But I also use it when looking up sentences for my own education. For instance, if I want to look up word X in Russian, it's important to me to see who contributed the matching sentences because their names serve as a quick index to the styles that I've become acquainted with.

It's true that this information would be less useful to a first-time visitor, but I really hope there's a way to provide it up front for those who use it all the time.

{{vm.hiddenReplies[35152] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 20 days ago May 11, 2020 at 10:15 PM link Permalink

> The tooltip should say "Show fewer features" rather than
> "Show less features".

Thanks, I will correct this.

> Also, the name of the owner of the sentence is extremely important
> information to me, and the fact that it is no longer displayed without
> my having to visit the sentence itself will disrupt my workflow.

The owner of the sentence should be displayed. Perhaps you are experiencing this bug (or a similar one):
https://github.com/Tatoeba/tatoeba2/issues/2221 ?

{{vm.hiddenReplies[35154] ? 'expand_more' : 'expand_less'}} hide replies show replies
AlanF_US AlanF_US 20 days ago May 12, 2020 at 12:16 PM link Permalink

I meant what CK mentioned below: the user name disappears in "display more" mode, and I don't want to have to keep switching modes.

{{vm.hiddenReplies[35160] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 16 days ago May 15, 2020 at 11:05 PM link Permalink

I have created an issue for this:
https://github.com/Tatoeba/tatoeba2/issues/2326

TRANG TRANG 4 days ago May 27, 2020 at 11:49 PM link Permalink

I deployed on the dev website the changes for the menu to be displayed above the sentence block when expanded.

Could you test it and let me know if this works for you?

{{vm.hiddenReplies[35374] ? 'expand_more' : 'expand_less'}} hide replies show replies
AlanF_US AlanF_US 4 days ago May 28, 2020 at 12:46 AM link Permalink

Yes, it looks good now. Thank you!

CK CK 20 days ago, edited 20 days ago May 12, 2020 at 1:22 AM, edited May 12, 2020 at 3:46 AM link Permalink

> Also, the name of the owner of the sentence is extremely important
> information to me, ...

I agree with this.

>> There's a button in the green toolbar which will expand the menu for all sentences and keep it expanded as you go from a page to another.

While we see the the owner's name in the "show less" version, when browsing while showing all the things we need using the "show more" version, we don't see the owners' names, which means we still need to constantly toggle between the two.

https://dev.tatoeba.org/eng/sen...ll_in/eng/none


Would it be possible to add a line above the tools, moving the sentence number and owner's name there, and always show all the tools?

This might likely solve some of the problems brought up by other members.

{{vm.hiddenReplies[35156] ? 'expand_more' : 'expand_less'}} hide replies show replies
CK CK 14 days ago, edited 14 days ago May 18, 2020 at 1:40 AM, edited May 18, 2020 at 2:04 AM link Permalink

Also, since adding OK ratings to sentences is something I often do, I would like to have the full toolbar shown all the time instead of in a collapsed mode.

The way it is now, I have to click to expand to either add a rating, or to see if I've already rated it or not. That's a lot of extra clicking.

I hope that you don't force us to use the new design until some of these issues are resolved.

{{vm.hiddenReplies[35214] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 4 days ago May 28, 2020 at 12:08 AM link Permalink

> The way it is now, I have to click to expand to either add a rating,
> or to see if I've already rated it or not. That's a lot of extra clicking.

There is a button in the toolbar to expand all the menus:
https://imgur.com/cDinvJe

> I hope that you don't force us to use the new design until some of these
> issues are resolved.

As mentioned back in April:

"We will still keep the possibility to switch back to the old sentence design via an option in the settings. This option will be available for a few weeks only, just enough time for us to ensure the features of the old sentence design have been covered properly in the new design. Then we will completely remove the old design."

https://tatoeba.org/eng/wall/sh...#message_34750

It is impossible to ensure that the new design will be perfect, but the goal is that it is usable enough. If you have other issues with the new design that heavily impacts your workflow, please report them.

CK CK 26 days ago, edited 26 days ago May 5, 2020 at 8:01 PM, edited May 5, 2020 at 8:02 PM link Permalink

I think that you shouldn't disable the traditional sentence design and force members to use the new sentence design until the website is fully mobile-friendly.

I know that one of the reasons that you haven't yet made tatoeba.org mobile-friendly is that you wanted to complete the new sentence design first.

My wish would be that you never disable the traditional sentence design, or at least delay disabling it for a year or so.

{{vm.hiddenReplies[35106] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 26 days ago May 5, 2020 at 8:17 PM link Permalink

What exactly blocks you from using the new design?

{{vm.hiddenReplies[35107] ? 'expand_more' : 'expand_less'}} hide replies show replies
Aiji Aiji 24 days ago, edited 24 days ago May 8, 2020 at 9:58 AM, edited May 8, 2020 at 10:08 AM link Permalink

I'm proofreading a user's sentences right now. Display 100 sentences a page.
1. When I clicked the "Show more features for all sentences", it took several seconds to change.
2. When I move my mouse over a translation or a translation of translation, the grey color takes some non-negligible time to appear. I mean by that that the human eye clearly see that it's not instant.
3. When I hover the copy icon, there is a tooltip, but no "hovering change of style". Doesn't really matter. However, when I click the button, during the time it takes to link the sentence, I have no indication that things are processing. Same for unlinking, so if I'm impatient, I click several time and I may unlink another sentence, that I will have to relink again.

I don't know if my browser has some responsibility in it, I don't think so, but all together, that gives a very laggy experience.

{{vm.hiddenReplies[35128] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 21 days ago May 10, 2020 at 8:16 PM link Permalink

1. That's optimization issues. Angular is very slow at rendering after a certain amount of items in ng-repeat :/

2. I suppose you moved your mouse over a translation shortly after clicking the button to expand the menus? As long as the menu are not rendered, other interactions with the UI have to wait. That's why the grey background appears only after some time.

3. None of the icons have a hovering style. They all have a tooltip though. That should be enough(?). If we decide to change the color on hover for the copy icon, we have to do it for all icons.
As for the progress indicator, I suppose you're talking about the link/unlink icons and not the copy button. For this, I have updated the code so that every icon that involve an HTTP call have a loading animation. You can test it on dev.

PaulP PaulP 21 days ago, edited 21 days ago May 11, 2020 at 11:55 AM, edited May 11, 2020 at 11:59 AM link Permalink

IMHO this is really a step backwards. When I'm proofreading sentences, e.g. through the menu item "Browse by language", I don't see the 3 review icons. Everytime, sentence after sentence, I have to click on "Show more features" in order to see them. Or am I missing something obvious?

P.S. Just now I see this comment:

> There's a button in the green toolbar which will expand the menu for all sentences and keep it expanded as you go from a page to another.

Where? I dont find it.

{{vm.hiddenReplies[35146] ? 'expand_more' : 'expand_less'}} hide replies show replies
rumpelstilzchen rumpelstilzchen 20 days ago May 11, 2020 at 4:28 PM link Permalink

>> There's a button in the green toolbar which will expand the menu for all sentences and keep it expanded as you go from a page to another.

> Where? I dont find it.

See https://imgur.com/cDinvJe
It's the icon on the right side with the upward and downward arrows.

{{vm.hiddenReplies[35147] ? 'expand_more' : 'expand_less'}} hide replies show replies
PaulP PaulP 20 days ago May 11, 2020 at 4:39 PM link Permalink

Ok, Thanks, Rumpelstilzchen! Now I found it. But that button appears only in the "Browse by language" menu. It does not appear in "Latest contributions" or in the "Browse by tag", which is rather important for corpus maintainers browsing through sentences with the tags @change, @check etc.

{{vm.hiddenReplies[35148] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 20 days ago May 11, 2020 at 7:38 PM link Permalink

> It does not appear in "Latest contributions" or in the "Browse by tag"

This button wouldn't have any use in the "Latest contributions". Or maybe I don't understand which page you mean. Do you mean this page:
https://tatoeba.org/eng/contributions/latest ?

For the "Browse by tag" page, it was forgotten and can be added for next week.

{{vm.hiddenReplies[35150] ? 'expand_more' : 'expand_less'}} hide replies show replies
PaulP PaulP 20 days ago May 12, 2020 at 5:53 AM link Permalink

>>It does not appear in "Latest contributions" or in the "Browse by tag"

>Do you mean this page:
https://tatoeba.org/eng/contributions/latest ?

Yes, but you are right. There it's not much of importance.

>For the "Browse by tag" page, it was forgotten and can be added for next week.

Thanks!

AlanF_US AlanF_US 20 days ago May 11, 2020 at 9:53 PM link Permalink

When I look at the sentences I've reviewed:

https://dev.tatoeba.org/eng/reviews/of/AlanF_US

there's a box "Filter" in the upper right-hand corner. Within that box, the items "Sentences marked as 'OK'", "Sentences marked as 'unsure'", and "Sentences marked as 'not OK'" are preceded by the checkmark, question mark, and exclamation mark icons. However, the icons are in gray. It would make more sense for them to be in green, orange, and red, as they are next to the sentences.

{{vm.hiddenReplies[35153] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 15 days ago May 17, 2020 at 11:15 AM link Permalink

I created an issue in GitHub:
https://github.com/Tatoeba/tatoeba2/issues/2333

{{vm.hiddenReplies[35202] ? 'expand_more' : 'expand_less'}} hide replies show replies
AlanF_US AlanF_US 14 days ago May 17, 2020 at 2:36 PM link Permalink

Thanks!

CK CK 4 days ago, edited 4 days ago May 28, 2020 at 2:31 AM, edited May 28, 2020 at 2:34 AM link Permalink

+1
Color icons are much faster to recognize, even if only by a micro-second.

I think it might even be a good idea to add color into the icons on the tool bar of the new design for some of the tools.

CK CK 14 days ago, edited 14 days ago May 18, 2020 at 2:01 AM, edited May 18, 2020 at 2:10 AM link Permalink

"Search list or enter new list name"

This has a button that says "Create" which doesn't match the "search" option.

I accidentally created a new list in the following manner.

After searching for the list by entering a partial word, I clicked the checkbox in front of the list's name, then clicked the only visible button on the page to submit it to the list.

I realize that I should have been more careful, but I wonder if this will happen to others, too, who don't realize that you need to scroll to the "close" that may be off screen. (It was for me.)


{{vm.hiddenReplies[35216] ? 'expand_more' : 'expand_less'}} hide replies show replies
TRANG TRANG 13 days ago May 18, 2020 at 3:15 PM link Permalink

I've created an issue on GitHub:
https://github.com/Tatoeba/tatoeba2/issues/2337

AlanF_US AlanF_US 4 days ago May 28, 2020 at 12:55 AM link Permalink

Deselecting "Display a link to expand/collapse translations when there are too many translations" doesn't seem to have any effect. I still see strings like "Show 1 more translation" next to a down-arrow. This is true even when I close the browser and come back. I'm using Firefox on Windows.